docs: add new doc for multi-page scenarios #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jun 29, 2020
docs/multi-pages.md
Outdated
| const pageTwo = await context.newPage(); | ||
|
|
||
| // Get pages of a brower context | ||
| const allPages = await context.pages(); |
There was a problem hiding this comment.
There is no need to await pages(), it is sync.
docs/multi-pages.md
Outdated
| console.log(await newPage.title()); | ||
|
|
||
| // Get all new pages (including popups) in the context | ||
| context.on('page', page => { |
There was a problem hiding this comment.
async page => ...for it to compile :)- same thing about domcontentloaded
docs/multi-pages.md
Outdated
| await popup.title(); | ||
|
|
||
| // Get all popups when they open | ||
| page.on('popup', popup => { |
There was a problem hiding this comment.
Same here:
- async
- waitForLoadState
| context.waitForEvent('page'), | ||
| page.evaluate(() => window.open('https://google.com', '_blank')) | ||
| ]) | ||
| console.log(await newPage.title()); |
There was a problem hiding this comment.
You'll need at least domcontentloaded before accessing title, but preferably load for everything else.
await newPage.waitForLoadState('domcontentloaded');There was a problem hiding this comment.
Thanks. Updated to use newPage.waitForLoadState() since that covers more scenarios for the audience of a guide like this.
| page.waitForEvent('popup'), | ||
| page.click('#open') | ||
| ]); | ||
| await popup.title(); |
There was a problem hiding this comment.
Use popup.waitForLoadState()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2602