fix(storageState): try to collect storage state on existing pages first #29915
+91
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps in a case where navigating to an origin fails for some reason, for example because a registered service worker loads some content into the supposedly blank page.
yury-s
approved these changes
Mar 12, 2024
Test results for "tests 1"1 failed 5 flaky26954 passed, 631 skipped Merge workflow run. |
mxschmitt
added a commit
to microsoft/playwright-dotnet
that referenced
this pull request
Mar 27, 2024
mxschmitt
added a commit
to mxschmitt/playwright-python
that referenced
this pull request
Mar 27, 2024
mxschmitt
added a commit
to microsoft/playwright-python
that referenced
this pull request
Mar 27, 2024
YusukeIwaki
added a commit
to YusukeIwaki/playwright-ruby-client
that referenced
this pull request
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps in a case where navigating to an origin fails for some reason, for example because a registered service worker loads some content into the supposedly blank page.
Fixes #29402.