Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add REPORT_ONLY mode for test collection #3225

Merged
merged 1 commit into from
Jul 31, 2020
Merged

test: add REPORT_ONLY mode for test collection #3225

merged 1 commit into from
Jul 31, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Jul 30, 2020

No description provided.

@JoelEinbinder
Copy link
Contributor

This wouldn't work for an external user who uses one of the globals we don't override. Like test or todo. I don't know what the requirements are for this code though.

@pavelfeldman ptal

@dgozman
Copy link
Contributor Author

dgozman commented Jul 30, 2020

This wouldn't work for an external user who uses one of the globals we don't override. Like test or todo. I don't know what the requirements are for this code though.

@pavelfeldman ptal

Oh, this is for our internal test collection and reporting. It only makes sense together with skip/fail, so we wouldn't bring this to external users unless we bring skip/fail.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not to make the test function noop? Would be a single line change or what do I miss?

@dgozman
Copy link
Contributor Author

dgozman commented Jul 30, 2020

Why not to make the test function noop? Would be a single line change or what do I miss?

This is what I do, but we also need to collect the skip/fail status and test location.

@dgozman
Copy link
Contributor Author

dgozman commented Jul 31, 2020

Please take another look, I've simplified things a bit.

Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I meant!

@dgozman dgozman merged commit 3edfb2a into microsoft:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants