feat(screenshot): create directories for screenshot file #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwoll
added a commit
to rwoll/playwright
that referenced
this pull request
Jul 31, 2020
This is to match the behavior for screenshots path added in microsoft#3247.
rwoll
added a commit
to rwoll/playwright
that referenced
this pull request
Jul 31, 2020
This is to match the behavior for screenshots path added in microsoft#3247.
pavelfeldman
pushed a commit
that referenced
this pull request
Jul 31, 2020
This is to match the behavior for screenshots path added in #3247.
|
🚢 it! @JoelEinbinder I've matched the |
dgozman
reviewed
Aug 7, 2020
JoelEinbinder
force-pushed
the
screenshot_mkdir
branch
from
109113a
to
cf63ee8
Compare
done. |
dgozman
approved these changes
Aug 17, 2020
JoelEinbinder
force-pushed
the
screenshot_mkdir
branch
from
cf63ee8
to
9212bbb
Compare
JoelEinbinder
force-pushed
the
screenshot_mkdir
branch
from
9212bbb
to
8b665d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs mkdir before writeFile for screenshots. This makes the screenshot api a bit nicer to use. I also added a test for the path argument, because it turns out it was completely untested!
fixes #2930