chore: move permissions API into features/ #33
Conversation
| An array of all pages inside the browser context. | ||
|
|
||
| #### browserContext.permissions | ||
| - returns: <[Permissions]> |
There was a problem hiding this comment.
Should this and other feature accessors be returns: <?[Permissions]> ?
There was a problem hiding this comment.
That's a good point, I'll apply it to everything in a separate patch.
| #### browserContext.permissions | ||
| - returns: <[Permissions]> | ||
|
|
||
| #### browserContext.targets() |
There was a problem hiding this comment.
I thought you were going to drop targets from the API, is there a reason we must keep them? For testing/automation use cases where the browser is fully controlled by a program we shouldn't need this as the program should already be aware of all targets.
Oh, on the second look it seems that this place didn't actually change and it's just a misleading diff representation, so we can discuss this separately.
There was a problem hiding this comment.
Yup. Will remove later...
| @@ -131,7 +131,9 @@ module.exports.addTests = ({testRunner, product, playwrightPath}) => { | |||
|
|
|||
| // Page-level tests that are given a browser, a context and a page. | |||
| // Each test is launched in a new browser context. | |||
| require('../src/chromium/features/accessibility.spec.js').addTests(testOptions); | |||
There was a problem hiding this comment.
Commit description should mention Accessibility changes as well.
No description provided.