feat(firefox): migrate to protocol-based proxy implementation #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share why this is better than the options way? Options were easy to maintain (no juggler, no fork). |
yury-s
approved these changes
Aug 11, 2020
| aType = 'socks'; | ||
| else if (proxyServer.protocol === 'socks4:') | ||
| aType = 'socks4'; | ||
| else if (proxyServer.protocol === 'https:') |
There was a problem hiding this comment.
Is it supported in other browsers? If no, let's update the docs.
There was a problem hiding this comment.
It does work in Chromium! WebKit is all different across platforms - I haven't checked yet.
aslushnikov
force-pushed
the
firefox-global-proxy
branch
from
f60c071
to
789cfaa
Compare
This migrates Firefox to the protocol-based proxy implementation. Benefits: - supports secure web proxies (already supported by Chromium) - unlocks support for SOCKS proxies with authentication
aslushnikov
force-pushed
the
firefox-global-proxy
branch
from
789cfaa
to
ec7430f
Compare
aslushnikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Firefox to the protocol-based proxy implementation.
This enables secure web proxies in firefox that are already supported by Chromium.