chore(tests): convert all tests to typescript #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelEinbinder
force-pushed
the
rest_of_ts_tests
branch
from
eb5ed26
to
f262657
Compare
pavelfeldman
approved these changes
Aug 11, 2020
JoelEinbinder
force-pushed
the
rest_of_ts_tests
branch
from
f262657
to
438ea0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the rest of the tests to typescript. While mostly marking some global variables as any, there are quite a few real fixes here like
isMobilebeing in the viewport options, calling selectOption with varargs, and a test "should tolerate waitFor=visible" that wasn't actually testing anything.