Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace-viewer): Render context string for most actions #34292

Merged
merged 17 commits into from
Jan 16, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 10, 2025

We display a friendly descriptor of an action that uses a locator next to the action in Trace Viewer. This adds the display of context of other actions (keyboard, mouse, etc) in a separate color to discriminate them from locators.

Notably, this only applies to the Trace Viewer display of actions; all other UI remains the same due to various issues that arise with providing similar UI. The only other places this UI is referenced is in the codegen recorder, which I don't believe can produce any of the relevant actions (all codegen actions will directly use a selector), and the Trace Viewer recorder experiment, which has the exact same reasoning.

Screenshot 2025-01-10 at 7 49 52 AM

Addresses #34093

@agg23 agg23 requested a review from pavelfeldman January 10, 2025 15:56

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@agg23 agg23 requested a review from pavelfeldman January 15, 2025 13:45

This comment has been minimized.

packages/trace-viewer/src/ui/actionList.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/actionList.tsx Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/string.ts Outdated Show resolved Hide resolved
packages/trace-viewer/src/ui/string.ts Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

packages/trace-viewer/src/ui/actionList.tsx Show resolved Hide resolved
packages/trace-viewer/src/ui/actionList.tsx Outdated Show resolved Hide resolved
@agg23 agg23 merged commit 84bbc5f into microsoft:main Jan 16, 2025
29 checks passed
Copy link
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:178:3 › should exclude patterns @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:352:5 › selector generator › should match in shadow dom @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:245:3 › should upload large file with relative path @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37602 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants