Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bidi): Stop dividing BiDi network event timings by 1000 #34324

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

juliandescottes
Copy link
Contributor

BiDi network event timings are already in milliseconds. They are computed from DOMHighResTimeStamp(s) https://www.w3.org/TR/hr-time-3/#dom-domhighrestimestamp

I assume the rest of the playwright codebase expects milliseconds. This makes at least one additional test pass:

library/har.spec.ts :: should return receive time

Copy link
Contributor

Test results for "tests 1"

8 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:117:5 › should run component tests after editing test and component @ubuntu-latest-node20-1
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1496:1 › should not leak recorders @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show only one pointer with multilevel iframes @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37585 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

}
const timing: network.ResourceTiming = {
startTime: startTime / 1000,
startTime: startTime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
startTime: startTime,
startTime,

@yury-s yury-s merged commit 0869195 into microsoft:main Jan 14, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants