test: allow overriding the worker fixtures #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
runner3
branch
2 times, most recently
from
43bec32
to
fea6e5e
Compare
dgozman
approved these changes
Aug 14, 2020
| // At this point, filesWithRegistrations contains all the files with worker fixture registrations. | ||
| // For every test, build the require closure and map each file to fixtures declared in it. | ||
| // This collection of fixtures is the fingerprint of the worker setup, a "worker hash". | ||
| // Tests with the matching "worker hash" will reuse the same worker. |
There was a problem hiding this comment.
If I have a server worker fixture, and I add an unrelated pokemon worker fixture in my test, does this mean I will get a new server instance?
There was a problem hiding this comment.
Yes, you will. I can trace fixture usages and overrides to mitigate this.
There was a problem hiding this comment.
Having said that, I am not sure it is critical - all I did was I recycled your worker...
There was a problem hiding this comment.
We can do it later. Just trying to make sure I understand what im reading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.