Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge Browser{Context,}Base into Browser{Context,} #3524

Merged
merged 1 commit into from
Aug 19, 2020
Merged

chore: merge Browser{Context,}Base into Browser{Context,} #3524

merged 1 commit into from
Aug 19, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Aug 19, 2020

No description provided.

yury-s
yury-s approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the sole reason there was BrowserContext interface is that it clearly separated public API from the private details which was rather convenient, don't we need it anymore?

@dgozman
Copy link
Contributor Author

dgozman commented Aug 19, 2020

I believe the sole reason there was BrowserContext interface is that it clearly separated public API from the private details which was rather convenient, don't we need it anymore?

All the public APIs moved to src/rpc/client, so these interfaces do not server any purpose anymore.

@dgozman dgozman merged commit 745dc33 into microsoft:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgozman @pavelfeldman @yury-s