Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: take a screenshot upon failure example #3556

Merged
merged 1 commit into from
Aug 21, 2020
Merged

test: take a screenshot upon failure example #3556

merged 1 commit into from
Aug 21, 2020

Conversation

pavelfeldman
Copy link
Member

drive-by timeout for test only.

dgozman
dgozman approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

test/runner/fixtures.js Outdated Show resolved Hide resolved
test/test-runner.spec.ts Outdated Show resolved Hide resolved
@pavelfeldman pavelfeldman merged commit 83f3995 into microsoft:master Aug 21, 2020
@aslushnikov aslushnikov mentioned this pull request Aug 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

@JoelEinbinder JoelEinbinder JoelEinbinder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelfeldman @JoelEinbinder @dgozman