Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): use bundled ffmpeg instead of npm deps #3771

Merged
merged 2 commits into from
Sep 4, 2020
Merged

feat(chromium): use bundled ffmpeg instead of npm deps #3771

merged 2 commits into from
Sep 4, 2020

Conversation

aslushnikov
Copy link
Collaborator

@aslushnikov aslushnikov commented Sep 4, 2020 •
edited by mxschmitt
Loading

Fixes #3680

mxschmitt
mxschmitt requested changes Sep 4, 2020
View reviewed changes
src/utils/browserPaths.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
mxschmitt
mxschmitt approved these changes Sep 4, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: EOL in videoRecorder.ts changed. Otherwise LGTM!

@aslushnikov
Copy link
Collaborator Author

nit: EOL in videoRecorder.ts changed. Otherwise LGTM!

Which is probably for the good! 🤷‍♂️

@aslushnikov aslushnikov merged commit bbe2233 into microsoft:master Sep 4, 2020
@aslushnikov aslushnikov deleted the use-baked-ffmpeg-instead-of-npm-dependency branch September 4, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[health] bundle ffmpeg with Chromium
2 participants
@aslushnikov @mxschmitt