chore: expose internal api for extending injected script #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
extendApi
branch
2 times, most recently
from
2225f12
to
728db37
Compare
dgozman
approved these changes
Sep 7, 2020
| return; | ||
| (mainContext as any)[debugScriptSymbol] = true; | ||
| await mainContext.extendInjectedScript(debugScriptSource.source); | ||
| await frame.extendInjectedScript(debugScriptSource.source); |
There was a problem hiding this comment.
This is called on every navigation, including same-document. That means we can extend the same injected script twice. Is that ok?
There was a problem hiding this comment.
Clients would need to take care of it for now...
| @@ -410,6 +410,11 @@ export class Frame extends ChannelOwner<channels.FrameChannel, channels.FrameIni | |||
| return (await this._channel.title()).value; | |||
| }); | |||
| } | |||
|
|
|||
| async _extendInjectedScript<Arg>(source: string, arg?: Arg): Promise<JSHandle> { | |||
There was a problem hiding this comment.
Do you plan to call this one?
pavelfeldman
force-pushed
the
extendApi
branch
from
728db37
to
d52658f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.