feat: actually bundle FFMPEG binaries with NPM packages #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
reviewed
Sep 8, 2020
| const context = await browser.newContext(); | ||
| const page = await context.newPage(); | ||
| const videoFile = path.join(__dirname, requireName + '--' + browserType + '-v.webm'); | ||
| await playwright._toImpl(page)._delegate.startScreencast({outputFile: videoFile, width: 320, height: 240}); |
There was a problem hiding this comment.
ah looked at the wrong screencast test for the inspiration 🤷♂️
aslushnikov
force-pushed
the
actuall-bundle-ffmpegs-with-npm-packages
branch
from
170f6c3
to
9eb019b
Compare
This patch: - adds FFMPEG binaries to the NPM packages - adds a screencast test to make sure that screencast works Note: this currently relies on private screencast APIs.
aslushnikov
force-pushed
the
actuall-bundle-ffmpegs-with-npm-packages
branch
from
6f9ef20
to
a43c63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
NOTE: with this patch playwright package size grows from
650KBto4.2MB.