chore: fix compatibility to the domain module #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
bugfix/domaini-module
branch
4 times, most recently
from
8449585
to
67c96cb
Compare
pavelfeldman
approved these changes
Sep 11, 2020
mxschmitt
force-pushed
the
bugfix/domaini-module
branch
from
67c96cb
to
6c2e116
Compare
1 task
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Sep 14, 2020
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Sep 14, 2020
Cherry-picking microsoft#3851 References microsoft#3848
aslushnikov
added a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3848
When using the domain module (deprecated but still used widely) it's not allowed to use a property called
domainin a class which inherits from the EventEmitter. Before the tests timeout out.