fix(launchServer): do not throw when 'port' option is present #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use 'launch' under the hood, which erroneously throws when 'port' is present. Instead, moved validation to the client side where it belongs, added tests for validation errors.
JoelEinbinder
approved these changes
Sep 14, 2020
yury-s
approved these changes
Sep 14, 2020
aslushnikov
pushed a commit
to aslushnikov/playwright
that referenced
this pull request
Sep 14, 2020
This cherry-picks PR microsoft#3877 References microsoft#3872
aslushnikov
added a commit
that referenced
this pull request
Sep 15, 2020
…3881) This cherry-picks PR #3877 References #3872 Co-authored-by: Dmitry Gozman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use 'launch' under the hood, which erroneously throws when 'port' is present.
Instead, moved validation to the client side where it belongs, added tests for validation errors.