devops: playwwright-core installation should not touch browser registry #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `playwright-core` installation would check browser registry and remove any unused browsers. This, however, might be unexpected since `playwright-core` shouldn't touch browser registry at all. Fixes microsoft#4083
|
This looks good, but why is this harmful? Should be a noop? |
pavelfeldman
approved these changes
Oct 7, 2020
mxschmitt
approved these changes
Oct 8, 2020
aslushnikov
deleted the
playwright-core-to-avoid-touching-browser-registry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
playwright-coreinstallation would check browser registryand remove any unused browsers. This, however, might be unexpected
since
playwright-coreshouldn't touch browser registry at all.Fixes #4083