Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable chromium sandbox by default #4090

Merged
merged 3 commits into from
Oct 9, 2020
Merged

fix: disable chromium sandbox by default #4090

merged 3 commits into from
Oct 9, 2020

Commits on Oct 7, 2020

  1. fix: disable chromium sandbox by default 

    Certain environments, e.g. Azure Pipelines, override default user
inside container with a custom one, whereas fail to pass proper
seccomp profile for the docker image.

As a result, chromium sandboxing fails.

To ease life of devops deploying tests in various CI's, this patch
disables Chromium sandbox by default.

References microsoft#4084
    @aslushnikov
    aslushnikov committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    e0e6d29 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. remove logic that auto-enabled --no-sandbox in case of root user

    @aslushnikov
    aslushnikov committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    b66078a View commit details
    Browse the repository at this point in the history

  2. fix lint

    @aslushnikov
    aslushnikov committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    38b9d72 View commit details
    Browse the repository at this point in the history