Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not report errored pages after context closure #4346

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: do not report errored pages after context closure #4346

merged 1 commit into from
Nov 5, 2020

Commits on Nov 4, 2020

  1. fix: do not report errored pages after context closure

    Consider the following sequence:
    - page opens a popup;
    - popup target is attached, we start initializing it;
    - user calls browser.close();
    - browser is closed, and popup initialization fails;
    - we report "errored page" on the already closed context;
    - RPC client cannot make sense of this:
      "Cannot find parent object BrowserContext@guid to create Frame@guid"
    
    This issue was revealed during Firefox pipe migration.
    dgozman committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    6d4a07a View commit details
    Browse the repository at this point in the history