feat(goto): assume http:// for localhost navigations #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Feb 4, 2020
test/navigation.spec.js
Outdated
| @@ -28,6 +28,10 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI | |||
| await page.goto(server.EMPTY_PAGE); | |||
| expect(page.url()).toBe(server.EMPTY_PAGE); | |||
| }); | |||
| fit('should use http for no protocol', async({page, server}) => { | |||
There was a problem hiding this comment.
Shouldn't this test localhost url? Also, no fit please :)
There was a problem hiding this comment.
Yeah, bot's aren't happy with fits!
| @@ -211,6 +211,12 @@ class Helper { | |||
| tokens.push('$'); | |||
| return new RegExp(tokens.join('')); | |||
| } | |||
|
|
|||
| static completeUserURL(urlString: string): string { | |||
| if (urlString.startsWith('localhost') || urlString.startsWith('127.0.0.1')) | |||
There was a problem hiding this comment.
Perhaps allow 0:0:0:0:0:0:0:1 and ::1 as well?
There was a problem hiding this comment.
I'd strongly encourage using URLs where urls are required. localhost and 127.0.0.1 are too wide-spread to ignore, but ipv6 is not (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803