feat(check): introduce page.check/uncheck #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Feb 4, 2020
src/dom.ts
Outdated
|
|
||
| private async _setChecked(state: boolean) { | ||
| const isCheckboxChecked = async (): Promise<boolean> => { | ||
| return this.evaluate((node: Node) => { |
There was a problem hiding this comment.
Use this._evaluateInUtility.
| @@ -405,4 +405,41 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI | |||
| expect(await page.evaluate('document.querySelector("#button").style.left')).toBe('0px'); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('Page.check', function() { | |||
There was a problem hiding this comment.
We should follow up with checking radio buttons (IIRC, WebDriver does it).
There was a problem hiding this comment.
Added radio into the mix
| expect(await page.evaluate(() => checkbox.checked)).toBe(false); | ||
| }); | ||
| it('should check the box by label', async({page}) => { | ||
| await page.setContent(`<label for='checkbox'><input id='checkbox' type='checkbox'></input></label>`); |
There was a problem hiding this comment.
Could you please add the following tests?
Checkbox not inside the label:
<label for='checkbox'>Text</label><div><input id='checkbox' type='checkbox'></input></div>
Checkbox inside a label without for=.
<label>Text<span><input id='checkbox' type='checkbox'></input></span></label>
aslushnikov
reviewed
Feb 4, 2020
docs/api.md
Outdated
| - `selector` <[string]> A selector to search for checkbox to check. If there are multiple elements satisfying the selector, the first will be checked. | ||
| - `options` <[Object]> | ||
| - `waitFor` <"visible"|"hidden"|"any"|"nowait"> Wait for element to become visible (`visible`), hidden (`hidden`), present in dom (`any`) or do not wait at all (`nowait`). Defaults to `visible`. | ||
| - `timeout` <[number]> Maximum navigation time in milliseconds, defaults to 30 seconds, pass `0` to disable timeout. The default value can be changed by using the [page.setDefaultTimeout(timeout)](#pagesetdefaulttimeouttimeout) method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.