Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firefox): lint against the juggler protocol #94

Merged
merged 2 commits into from
Dec 4, 2019
Merged

chore(firefox): lint against the juggler protocol #94

merged 2 commits into from
Dec 4, 2019

Conversation

JoelEinbinder
Copy link
Contributor

@JoelEinbinder JoelEinbinder commented Nov 26, 2019

closes #9

@@ -97,6 +97,11 @@ module.exports.addTests = function({testRunner, expect, CHROME, FFOX, WEBKIT}) {
else if (FFOX)
expect(error.message).toContain('Object is not serializable');
});
fit('should work with tricky values', async({page, server}) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fit!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. Thanks!

@JoelEinbinder JoelEinbinder merged commit 492f539 into microsoft:master Dec 4, 2019
@JoelEinbinder JoelEinbinder deleted the firefox_protocol branch December 4, 2019 18:33
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firefox protocol checking
3 participants