Fix the bug of reading string NA as NaN in the function exists_qlib_data. #1736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug of reading string NA as NaN of exists_qlib_data in /qlib/utils/__init__.py.
Description
Nano Labs Ltd is a new Nasdaq-listing company with the ticker name NA from August 1, 2022. The default na_value list of pd.read_csv includes "NA". Changed the default reading behavior of pd.read_csv in
exists_qlib_data
by addingkeep_default_na=False
. Removed two values ("NA" and "NULL") from the default NA list while reading the first column of "all.txt", which normally are all strings.Motivation and Context
To fix the bug in #1720.
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.py
under upper directory ofqlib
.Screenshots of Test Results (if appropriate):
Pipeline test:
Your own tests:
Place the attached file all.txt under \qlib_data\us_data_made\instruments and test with the following code
Types of changes