Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimalloc is vendored instead of fetched #1320

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Mar 27, 2024

These changes copy a snapshot of the Mimalloc source from v2.1.2 into the mimalloc-sys folder so that we no longer need to use cmake to fetch and prepare the source. This also fixes aarch64 Windows cross-compilation issues caused by cmake generators.

I have addressed all DevSkim feedback and nothing was applicable or actionable.

I've run the release build and everything compiles. It shows a red X in the checks as I cancelled the second half of the build to prevent the release from going out.

Closes #1281

@idavis idavis self-assigned this Mar 27, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

Benchmark for 4faef03

Click to view benchmark
Test Base PR %
Array append evaluation 345.6±2.03µs 352.5±5.59µs +2.00%
Array literal evaluation 171.4±4.44µs 193.8±7.48µs +13.07%
Array update evaluation 427.5±1.47µs 435.9±4.76µs +1.96%
Deutsch-Jozsa evaluation 5.3±0.12ms 5.2±0.08ms -1.89%
Large file parity evaluation 33.7±0.15ms 33.7±0.46ms 0.00%
Large input file 35.6±0.73ms 35.2±0.86ms -1.12%
Large nested iteration 33.8±0.20ms 34.7±0.63ms +2.66%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1645.5±145.15µs 1651.8±169.55µs +0.38%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.3±0.12ms 8.3±0.13ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1573.8±173.83µs 1564.0±178.23µs -0.62%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 22.5±0.39ms 22.2±0.21ms -1.33%
Standard library 19.6±0.43ms 20.0±0.67ms +2.04%
Teleport evaluation 86.3±5.20µs 86.1±9.04µs -0.23%

Copy link

Benchmark for 8f07453

Click to view benchmark
Test Base PR %
Array append evaluation 342.0±6.77µs 345.6±10.00µs +1.05%
Array literal evaluation 166.6±3.86µs 170.5±1.59µs +2.34%
Array update evaluation 416.4±8.83µs 421.5±2.23µs +1.22%
Deutsch-Jozsa evaluation 5.1±0.07ms 5.1±0.11ms 0.00%
Large file parity evaluation 33.5±0.13ms 33.5±0.37ms 0.00%
Large input file 33.6±0.96ms 28.2±0.93ms -16.07%
Large nested iteration 32.5±0.84ms 33.3±0.63ms +2.46%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1618.6±167.09µs 1587.2±74.44µs -1.94%
Perform Runtime Capabilities Analysis (RCA) on large file sample 8.0±0.18ms 7.8±0.16ms -2.50%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1512.2±108.59µs 1517.3±74.93µs +0.34%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.3±0.51ms 21.2±0.43ms -0.47%
Standard library 18.5±0.70ms 16.4±0.21ms -11.35%
Teleport evaluation 84.0±4.11µs 86.2±8.94µs +2.62%

README.md Outdated Show resolved Hide resolved
@idavis idavis requested a review from minestarks March 28, 2024 18:31
Copy link

Benchmark for bb4a6ed

Click to view benchmark
Test Base PR %
Array append evaluation 341.9±2.66µs 362.5±27.67µs +6.03%
Array literal evaluation 174.7±4.35µs 181.9±5.87µs +4.12%
Array update evaluation 423.0±3.28µs 436.2±11.32µs +3.12%
Deutsch-Jozsa evaluation 5.1±0.13ms 5.2±0.15ms +1.96%
Large file parity evaluation 33.9±0.17ms 33.8±0.23ms -0.29%
Large input file 31.1±1.39ms 33.8±1.41ms +8.68%
Large nested iteration 33.6±1.53ms 33.8±1.00ms +0.60%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1516.4±59.38µs 1512.6±59.97µs -0.25%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.16ms 7.8±0.10ms -1.27%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1435.7±70.49µs 1442.3±85.08µs +0.46%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.5±0.33ms 21.6±0.59ms +0.47%
Standard library 17.1±0.77ms 17.5±1.40ms +2.34%
Teleport evaluation 82.5±3.78µs 83.6±3.94µs +1.33%

@idavis idavis added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit 91589c3 Mar 28, 2024
16 checks passed
@idavis idavis deleted the iadavis/vendor-mimalloc branch March 28, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mimalloc build infra
3 participants