Consolidate built files into Libraries folder #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmelmon
reviewed
Jul 3, 2019
| module: 'commonjs', | ||
| }); | ||
| }); | ||
| task('clean', () => { | ||
| return cleanTask( | ||
| ['lib', 'temp', 'dist', 'coverage'].map(p => path.join(process.cwd(), p)), | ||
| ['Libraries', 'RNTester', 'lib'].map(p => path.join(process.cwd(), p)), |
There was a problem hiding this comment.
RNTester [](start = 19, length = 8)
The getting started guide (https://github.com/microsoft/react-native-windows/blob/master/vnext/docs/GettingStarted.md) will need updating to point folks at the new location for RNTester.
|
Pushing before updating other things, since other people changing files while I'm trying to move them risks accidentally losing changes during merges. |
This was referenced Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to work with the existing hasteImpl and plugin system of react-native, the built npm package should have all the haste modules in the Libraries folder. Currently they are split across the Libraries folder and lib/Libraries, which causes us to require a custom haste impl, which the default RN getPlugins infrastructure doesn't pick up.
This will also be a requirement in 0.60 when react-native drops haste entirely.
In order to do this
Microsoft Reviewers: Open in CodeFlow