Workaround for metro monorepo asset issues #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 hours. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
asklar
approved these changes
Jul 17, 2020
dannyvv
approved these changes
Jul 17, 2020
| @@ -32,6 +32,19 @@ module.exports = { | |||
| ), | |||
| ]), | |||
| }, | |||
|
|
|||
| // Metro doesn't currently handle assets from other packages within a monorepo. This is the current workaround people use | |||
| server: { | |||
There was a problem hiding this comment.
just for consideration: Since these are so identical, should we place it in a seperate js file and have something like server: require('../shared.metro.config.js').server
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in the playground/E2E app some of the images on the RNTester image page, and within the logbox experience do not show up when debugging. This is due to an issue with metro not able to handle assets that are located outside of the app's package folder, which is often the case in monorepos.
This change applies a workaround that the community uses for this case, which fixes this images within our repo. Hopefully this is something we can look into fixing in metro in the future.
See facebook/metro#290 (comment)
Microsoft Reviewers: Open in CodeFlow