-
Notifications
You must be signed in to change notification settings - Fork 855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question/feature request] How to know if programmatically loaded configuration has been applied or not? #1619
Labels
Type: Enhancement
New feature or request
Milestone
Comments
Triage: Looks like reasonable request. |
karelz
added
Type: Enhancement
New feature or request
and removed
Type: Idea
This issue is a high-level idea for discussion.
labels
Mar 24, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
May 24, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
May 30, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Jul 5, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Jul 5, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Jul 6, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Jul 22, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Aug 16, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Aug 16, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Aug 16, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Aug 18, 2022
nulltoken
added a commit
to nulltoken/reverse-proxy
that referenced
this issue
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What should we add or change to make your life better?
When dynamically applying loaded configuration (cf. https://microsoft.github.io/reverse-proxy/articles/config-providers.html) after the initial startup, any validation failure will be logged, then silenced.
We would need a way to get notified of both successful configuration changes and invalid configuration rejection.
Why is this important to you?
InMemoryConfigProvider.Update()
is invoked, there is no way to tell if the configuration has been properly updated or ignored. As such, we don't know how to bump the currently deployed version to the latest valid one. (or keep it as is because nothing changed)Disclaimer: This capability may already exist in YARP. I might just haven't found it.
The text was updated successfully, but these errors were encountered: