Import IslandGateway code #1
Conversation
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Superpower" Version="2.3.0" /> |
There was a problem hiding this comment.
Oof, unfortunate that there's a third-party dependency here. Looks like it'll be OK, but we'll need to either 3pn this (i.e. add a third-party-notices) or remove it.
I presume this is for the rules language, since it's a parser combinator library. I'm kinda expecting us to redesign that a bit, or we'd make our own parser. So this seems OK for now. I'll file a bug for adding a 3pn so we don't forget.
src/IslandGateway.CoreServicesBorrowed/IslandGateway.CoreServicesBorrowed.csproj
Outdated
Show resolved
Hide resolved
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="FluentAssertions" Version="5.10.0" /> |
There was a problem hiding this comment.
We generally don't use Fluent Assertions so we'll probably need to make a pass later to clean them up. Filing a bug for that.
test/IslandGateway.CoreServicesBorrowed.Test/IslandGateway.CoreServicesBorrowed.Test.csproj
Outdated
Show resolved
Hide resolved
...ndGateway.ServiceFabricIntegration.Tests/IslandGateway.ServiceFabricIntegration.Tests.csproj
Outdated
Show resolved
Hide resolved
test/IslandGateway.Common.Tests/IslandGateway.Common.Tests.csproj
Outdated
Show resolved
Hide resolved
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Autofac" Version="4.9.4" /> | ||
| <PackageReference Include="Autofac.Extras.Moq" Version="4.3.0" /> |
There was a problem hiding this comment.
Yeah, we don't want auto-mocking if we can avoid it. But that can be handled in #6
|
⬆️📅 |
|
I'll do a style pass once this is in. I'm hoping I can find something to automate it, but if not I can Ctrl-. my way to victory ;). |
Closes #17
Copied from https://github.com/dotnet/proxy/pull/17.
The main difference is that I put the IslandGateway projects directly under src/ samples/ and test/ instead of under a src/Gateway/ subfolder.