Account for header type when removing headers #1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334
Unlike
TryAddWithoutValidation
,HttpHeaders.Remove
will throw if the header name does not belong to the header collection type.As a result, trying to remove
foo
from content headers or trying to removeContent-Encoding
from request headers will result in an exception.Instead of trying to remove the header from both collections, we should check which collection the header belongs to first.