Add support for multi-value header routing #1639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Matching now treats multiple values as ORs. I.e.
Exact
/Prefix
must match any of the request values.NotContains
means the value must not match any request header.Values are further split based on the separator
,
(or;
forCookie
). A single outer pair of quotes is also removed before matching.This PR is generally slightly faster on simple (single-value) inputs, and (as expected) slower on multi-value ones.
Modes that may observe a perf degradation are
Exact
andPrefix
.I don't think the difference is prohibitive to the point that having an opt-out switch is needed.
Benchmark scenarios are defined here.
ToDo: Updating docs with the new behavior