Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overload ReassignProxyRequest to also accept a route update #1760

Merged
merged 6 commits into from
Jun 15, 2022
Merged

Overload ReassignProxyRequest to also accept a route update #1760

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd0495f
ReassignProxyRequest overload to also replace the route
latelylk Jun 10, 2022
fe4f927
Update ReassignProxyRequest to use the "routes, clusters" order
latelylk Jun 13, 2022
2b70ded
Extend ReassignProxyRequest tests to include overload
latelylk Jun 13, 2022
3711337
Beging -> Begin in comment
latelylk Jun 13, 2022
ce124d0
Update test/ReverseProxy.Tests/Model/HttpContextFeaturesExtensions.cs
MihaZupan Jun 14, 2022
c83c8b6
Add doc comment to ReassignProxyRequest overload
latelylk Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/ReverseProxy/Model/HttpContextFeaturesExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,22 @@ public static void ReassignProxyRequest(this HttpContext context, ClusterState c
};
context.Features.Set<IReverseProxyFeature>(newFeature);
}

// ReassignProxyRequest overload to also replace the route when updating IReverseProxyFeature
// See discussion in https://github.com/microsoft/reverse-proxy/discussions/1749
// and https://github.com/microsoft/reverse-proxy/issues/1752
public static void ReassignProxyRequest(this HttpContext context, ClusterState cluster, RouteModel route)
latelylk marked this conversation as resolved.
Show resolved Hide resolved
{
var oldFeature = context.GetReverseProxyFeature();
var destinations = cluster.DestinationsState;
var newFeature = new ReverseProxyFeature()
{
Route = route,
Cluster = cluster.Model,
AllDestinations = destinations.AllDestinations,
AvailableDestinations = destinations.AvailableDestinations,
ProxiedDestination = oldFeature.ProxiedDestination,
};
context.Features.Set<IReverseProxyFeature>(newFeature);
}
}