-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSockets over HTTP/2 #1978
Merged
Merged
WebSockets over HTTP/2 #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
reviewed
Dec 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I take it the telemetry for H2 WebSockets also "just work ™️" because ASP.NET exposes them the same way as H1?
test/ReverseProxy.FunctionalTests/Common/XunitLoggerProvider.cs
Outdated
Show resolved
Hide resolved
MihaZupan
reviewed
Dec 27, 2022
Nope, had to add it there too 😁 |
Co-authored-by: Miha Zupan <[email protected]>
Co-authored-by: Miha Zupan <[email protected]>
davidfowl
reviewed
Dec 29, 2022
Tratcher
commented
Dec 29, 2022
Tratcher
commented
Dec 29, 2022
MihaZupan
approved these changes
Jan 2, 2023
Co-authored-by: Miha Zupan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1375
Before this change the forwarder assumed that WebSockets always had to be forwarded using HTTP/1.1. Now it will honor the version and policy settings to decide which outgoing protocol to use. Request and response headers are adapted as needed. If HTTP/2 doesn't work then it can re-try with HTTP/1.1.
Notes: