Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [StringSyntax("Route")] to route patterns #2156

Merged
merged 4 commits into from
Jun 13, 2023

Conversation

divyeshio
Copy link
Contributor

Fixes #2148

Adds [StringSyntax("Route")] to route patterns

@divyeshio
Copy link
Contributor Author

@divyeshio please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@Tratcher Tratcher self-assigned this Jun 12, 2023
@Tratcher Tratcher added this to the YARP 2.x milestone Jun 12, 2023
@Tratcher Tratcher enabled auto-merge (squash) June 12, 2023 23:55
@divyeshio
Copy link
Contributor Author

Do you know reason why CI is still failing?

@Tratcher
Copy link
Member

It was a bad edit on my part. Should be fixed now.

@Tratcher Tratcher merged commit c29db40 into microsoft:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add [StringSyntax("Route")] to route patterns
2 participants