Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsPackable to true for the k8s project on non rtw builds #2286

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

benjaminpetit
Copy link
Member

Fix #2134

This will enable the package creation only for non rtw build, meaning that the NuGet will be created for nightly and preview builds.

@MihaZupan
Copy link
Member

I believe we wanted to re-enable only the nightly-build part that goes to the separate feed.
If we're shipping a preview version of YARP to NuGet, we don't want to also ship a preview of the k8s package. I don't know how we would go about disabling the publishing of this package only for the NuGet publishing though.

Ideally, we would find a way to do so without having to re-disable and re-enable this flag every time we publish a preview, but maybe that's an okay compromise given we don't release all that often.

@benjaminpetit
Copy link
Member Author

Then the only solution is to modify the powershell script that publishes the nuget to explicitly ignore this package (or even better, only publish a certain list of packages).

Any reason to not ship this package as a preview in the official nuget feed?

@Tratcher
Copy link
Member

Any reason to not ship this package as a preview in the official nuget feed?

We wouldn't want to ship an RC version for example.

Suggestion:

  • Make it always packable
  • Mark it as non-shipping
  • Update the release script to pull from '_microsoft-reverse-proxy-official\artifacts\release\shipping' (excluding symbol packages) instead of '_microsoft-reverse-proxy-official\PackageArtifacts'

@benjaminpetit benjaminpetit merged commit 4eee431 into microsoft:main Nov 8, 2023
7 checks passed
@MihaZupan MihaZupan added the Type: Infrastructure Infrastructure work that does not affect the actual shipping code label Apr 2, 2024
@MihaZupan MihaZupan added this to the YARP 2.1 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Infrastructure work that does not affect the actual shipping code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily build broken Yarp.Kubernetes.Controller
3 participants