Clarify websocket activity failure #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses outstanding feedback from @MihaZupan about the error reporting changes in #2167. The intent was to more correctly attribute blame for disconnects to something caused by the client or destination. For ActivityTimeouts the blame would go to whoever we were currently expecting data from. However, in the WebSocket case we may be expecting data in both ways all the time, and an ActivityTimeout can be considered a no-blame situation that deserves separate consideration.
I'm not sure if the same consideration should apply to gRPC/streaming.