Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix X-Forwarded-For for IPv4 with dual stack sockets #2399 #2400

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

hacst
Copy link
Contributor

@hacst hacst commented Feb 15, 2024

Fixes #2399 . As discussed there checks whether the RemoteIpAddress is a IPv4-Mapped IPv6 Address and maps it back to a real IPv4 address before turning it into a string for the X-Forwarded-For header.

Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MihaZupan MihaZupan added this to the v.Next milestone Feb 15, 2024
@MihaZupan MihaZupan enabled auto-merge (squash) February 15, 2024 22:31
@MihaZupan MihaZupan merged commit d918126 into microsoft:main Feb 15, 2024
7 checks passed
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants