-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for using daily builds #280
Conversation
Hello @Tratcher! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 54 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
</configuration> | ||
``` | ||
|
||
*NOTE: This NuGet.Config should be with your application unless you want nightly packages to potentially start being restored for other apps on the machine.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this, shouldn't we add a step like the following?
> dotnet add package Microsoft.ReverseProxy --version 1.0.0-*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's covered in the Getting Started guide. I could link to that from here.
@@ -33,7 +33,9 @@ If you're having trouble building the project, or developing in Visual Studio, p | |||
|
|||
# Getting started | |||
|
|||
Take a look at the [sample apps](samples/), for some examples of how to use YARP. We'll be publishing more [docs](https://microsoft.github.io/reverse-proxy/) and tutorials as the project develops! | |||
- Try our [previews](https://github.com/microsoft/reverse-proxy/releases). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why link to the releases page with "Try our previews"? That just gives you a zipped version of what you could have cloned from github when we snapped a release.
Why not provide instructions for using the preview from NuGet.org similar to what we're doing for the daily builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting point. The releases page already links to Getting Started instructions, but I've updated the releases to explicitly link to the package on nuget.org.
I should also make the first link here go to Getting Started, which includes the nuget instructions.
How's that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We've started publishing daily builds to a feed so this adds instructions for accessing them. They're copied wholesale from AspNetCore.
I'm also updating the readme to recommend previews and daily builds.
Fixes #271