Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch results with GO N #587

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Fix batch results with GO N #587

merged 1 commit into from
Mar 21, 2018

Conversation

kevcunnane
Copy link
Contributor

@kevcunnane kevcunnane requested a review from benrr101 March 8, 2018 00:50
@kevcunnane
Copy link
Contributor Author

Ping... can someone review this? The AppVeyor fail was in a separate (flaky) test so I'm blocked on a PR before I can check this in. THanks!

MattIrv
MattIrv approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@MattIrv MattIrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test failing here is just a flaky test that I've already disabled in another PR

@MattIrv
Copy link
Contributor

MattIrv commented Mar 21, 2018

@kevcunnane Is this ready to go? We're doing the next SQL Ops Studio release soon and it would be good to include this fix

@kevcunnane
Copy link
Contributor Author

Yep, I had thought I merged already - will do so now.

@kevcunnane kevcunnane merged commit 30c4b97 into master Mar 21, 2018
@kevcunnane kevcunnane deleted the fix/batchresults branch March 21, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kburtram kburtram kburtram approved these changes

@MattIrv MattIrv MattIrv approved these changes

@benrr101 benrr101 Awaiting requested review from benrr101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevcunnane @MattIrv @kburtram