Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu no longer displays bound keys again (after #3825) #3896

Closed
DHowett-MSFT opened this issue Dec 10, 2019 · 0 comments · Fixed by #3903
Closed

Dropdown menu no longer displays bound keys again (after #3825) #3896

DHowett-MSFT opened this issue Dec 10, 2019 · 0 comments · Fixed by #3903
Assignees
@zadjii-msft
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v0.8

Comments

@DHowett-MSFT
Copy link
Contributor

This no longer works. Possible regression from #3825?

image
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 10, 2019
@zadjii-msft zadjii-msft self-assigned this Dec 10, 2019
@zadjii-msft zadjii-msft mentioned this issue Dec 10, 2019
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 10, 2019
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Dec 10, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 10, 2019
@zadjii-msft zadjii-msft added this to the Terminal-1912 milestone Dec 10, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 10, 2019
@ghost ghost closed this as completed in #3903 Dec 11, 2019
ghost pushed a commit that referenced this issue Dec 11, 2019
@zadjii-msft
Re-add the keychords to the new tab flyout (#3903)
bb60db7 
## Summary of the Pull Request

On this month's episode of "Mike accidentally breaks this": 
  Mike forgets that `==` is defined on a pair of winrt objects as "do these point to the _SAME_ object", not "do they have the same values". 

This just slipped right through code review.

## References

Broken in #3825

## PR Checklist
* [x] Closes #3896
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

## Validation Steps Performed

Manually checked that these are still there
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 11, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v0.8
Development

Successfully merging a pull request may close this issue.

Re-add the keychords to the new tab flyout microsoft/terminal
2 participants
@DHowett-MSFT @zadjii-msft