Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add "next search match" and "prev search match" bind-able key for find operations #7695

Closed
lsemprini opened this issue Sep 21, 2020 · 2 comments · Fixed by #8917
Closed

Please add "next search match" and "prev search match" bind-able key for find operations #7695

lsemprini opened this issue Sep 21, 2020 · 2 comments · Fixed by #8917
Assignees
@zadjii-msft
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.7

Comments

@lsemprini
Copy link

Hi, thanks so much for Terminal! I would like to be able to bind a key to go to the next and previous search match in an existing "find" that I already have started. I don't see a way to do this at:

https://docs.microsoft.com/en-us/windows/terminal/customize-settings/key-bindings
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 21, 2020
@DHowett
Copy link
Member

DHowett commented Sep 22, 2020

Good idea! I'll hook this up to the Search epic #3920.

@DHowett DHowett added Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 22, 2020
@DHowett DHowett added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements labels Sep 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 22, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Sep 22, 2020
@DHowett DHowett mentioned this issue Sep 22, 2020
Open
20 tasks
@ghost ghost mentioned this issue Dec 8, 2020
Closed
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Dec 8, 2020
@Don-Vito Don-Vito mentioned this issue Dec 10, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue Jan 27, 2021
Merged
@zadjii-msft zadjii-msft self-assigned this Feb 2, 2021
@ghost ghost closed this as completed in #8917 Feb 18, 2021
ghost pushed a commit that referenced this issue Feb 18, 2021
@zadjii-msft @kaihugo
Add findNext, findPrev actions (#8917)
491cb21 
This PR is a resurrection of #8522. @Hegunumo has apparently deleted
their account, but the contribution was still valuable. I'm just here to
get it across the finish line.

This PR adds new action for navigating to the next & previous search
results. These actions are unbound by default. These actions can be used
from directly within the search dialog also, to immediately navigate the
results. 

Furthermore, if you have a search started, and close the search box,
then press this keybinding, _it will still perform the search_. So you
can just hit <kbd>F3</kbd> repeatedly with the dialog closed to keep
searching new results. Neat!

If you dispatch the action on the key down, then dismiss a selection on
a key up, we'll end up immediately destroying the selection when you
release the bound key. That's annoying. It also bothers @carlos-zamora
in #3758. However, I _think_ we can just only dismiss the selection on a
key up. I _think_ that's fine. It _seems_ fine so far. We've got an
entire release cycle to futz with it.

## Validation Steps Performed
I've played with it all day and it seems _crisp_.

Closes #7695 

Co-authored-by: Kiminori Kaburagi <[email protected]>
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 18, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #8917, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.7
3 participants
@DHowett @lsemprini @zadjii-msft