Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad default selection background color with light schemes #8716

Closed
austin-beer opened this issue Jan 6, 2021 · 2 comments · Fixed by #16789
Closed

Bad default selection background color with light schemes #8716

austin-beer opened this issue Jan 6, 2021 · 2 comments · Fixed by #16789
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@austin-beer
Copy link

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 1.4.3243.0

Steps to reproduce

  1. Update settings.json to use the One Half Light, Solarized Light, or Tango Light color schemes.
  2. Use the mouse to highlight some text.

Expected behavior

It's easy to see which text was selected.

Actual behavior

It's hard to see which text was selected because the default selectionBackground value is white, and that doesn't work well with light color schemes.

Proposed solution

Add selectionBackground values to all of the color schemes in defaults.json (or at least the light color schemes).

Related to

This issue is related to #3326, #3561, and #3580.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 6, 2021
@zadjii-msft
Copy link
Member

zadjii-msft commented Jan 8, 2021 •
edited
Loading

Okay, you're not wrong here. Part of the trick with these schemes is that they don't canonically include a selection color. Usually, they're just defined as a set of (foreground, background, 16-color table). The selection color is almost always just set by the terminal emulator. So if we were to add selection BG colors to these schemes, that would be some other customization that we're making to these schemes other than their usual definitions.

Though, I think I agree - until #3561 lands, the experience with these themes is just bad. I wonder if we could just use the "bright black" color for each of these schemes and have it work good enough.

Note

Walkthrough

Go through each of the "light" color schemes in defaults.json, and add a selectionBackground property which is set to the scheme's brightBlack.

This will probably end up in a team discussion, but it'll be helpful to have a concrete example to drive that discussion.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jan 8, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 22, 2021
@CyanideCentral CyanideCentral mentioned this issue Mar 31, 2021
Closed
@henryduong26

This comment was marked as off-topic.

Sign in to view
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Feb 17, 2023
Open
@zadjii-msft zadjii-msft moved this from Should be written to Walkthrough in issue in Terminal Walkthroughs Jul 10, 2023
@github-project-automation github-project-automation bot moved this to Should be written in Terminal Walkthroughs Jul 10, 2023
TahaHaksal added a commit to TahaHaksal/terminal that referenced this issue Oct 30, 2023
@TahaHaksal
Added selectionBackground to light color schemes (microsoft#8716)
af0ab0f
@TahaHaksal TahaHaksal mentioned this issue Oct 30, 2023
Merged
DHowett pushed a commit that referenced this issue Nov 6, 2023
@TahaHaksal
Added selectionBackground to light color schemes (#16243)
a5c269b 
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.
DHowett pushed a commit that referenced this issue Nov 7, 2023
@TahaHaksal @DHowett
Added selectionBackground to light color schemes (#16243)
b57bc7e 
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033166
Service-Version: 1.18
DHowett pushed a commit that referenced this issue Nov 7, 2023
@TahaHaksal @DHowett
Added selectionBackground to light color schemes (#16243)
95e4d0b 
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033167
Service-Version: 1.19
DHowett pushed a commit that referenced this issue Nov 7, 2023
@TahaHaksal @DHowett
Added selectionBackground to light color schemes (#16243)
d0f3d55 
Add a selectionBackground property which is set to the scheme's
brightBlack too all 3 of the light color schemes.

Related to #8716
It does not close the bug because as mentioned in the issue, when you
input numbers, they seem to be invisible in the light color schemes and
selecting them with the cursor doesn't reveal them.

(cherry picked from commit a5c269b)
Service-Card-Id: 91033166
Service-Version: 1.18
@uoRetr0 uoRetr0 mentioned this issue Feb 29, 2024
Merged
4 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Feb 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
@uoRetr0
Fix the bad default light theme selection background color (#16789)
6bc7b9e 
## Summary of the Pull Request
Fixed default selection background colors with light schemes. Default
color now matches the scheme and contrasts well
## References and Relevant Issues
none
## Detailed Description of the Pull Request / Additional comments
This is my first contribution ever :) Even though its simple, im happy
to help
## Validation Steps Performed

## PR Checklist
- [ ] Closes #8716 
- [ ] Tests added/passed
- [ ] Documentation updated
- If checked, please file a pull request on [our docs
repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
- [ ] Schema updated (if necessary)
@github-project-automation github-project-automation bot moved this from Walkthrough in issue to Done in Terminal Walkthroughs Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 29, 2024
@DHowett DHowett mentioned this issue Aug 15, 2024
Merged
DHowett added a commit that referenced this issue Aug 19, 2024
@DHowett
atlas: draw selection colors as background/foreground instead of alph…
faf21ac 
…a overlay (#17725)

With the merge of #17638, selections are now accumulated early in the
rendering process. This allows Atlas, which currently makes decisions
about cell foreground/background at the time of text rendering,
awareness of the selection ranges *before* text rendering begins.

As a result, we can now paint the selection into the background and
foreground bitmaps. We no longer need to overlay a rectangle, or series
of rectangles, on top of the rendering surface and alpha blend the
selection color onto the final image.

As a reminder, "alpha selection" was always a stopgap because we didn't
have durable per-cell foreground and background customization in the
original DxEngine.

Selection foregrounds are not customizable, and will be chosen using the
same color distancing algorithm as the cursor. We can make them
customizable "easily" (once we figure out the schema for it) for #3580.

`ATLAS_DEBUG_SHOW_DIRTY` was using the `Selection` shading type to draw
colored regions. I didn't want to break that, so I elected to rename the
`Selection` shading type to `FilledRect` and keep its value. It helps
that the shader didn't have any special treatment for
`SHADING_TYPE_SELECTION`.

This fixes the entire category of issues created by selection being an
80%-opacity white rectangle. However, given that it changes the imputed
colors of the text it will reveal `SGR 8` concealed/hidden characters.

Refs #17355
Refs #14859
Refs #11181
Refs #8716
Refs #4971
Closes #3561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Done
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix the bad default light theme selection background color uoRetr0/terminal
4 participants
@DHowett @zadjii-msft @austin-beer @henryduong26