Initial try for connection restart

[skyline75489]

Summary of the Pull Request

This targets #3726 & #4379

Surprisingly, it works.

References

PR Checklist

• Closes #xxx
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
• Schema updated.
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[skyline75489]

/cc @zadjii-msft. WDYT? Does this looks like the correct way?

[lhecker]

Don't we have to kill the client before creating a new one?

[DHowett]

So! In this case, I think it would be better for us to delete the old connection object and create a new one. That will simplify the Connection interface (not all connections can be "restarted"), and you will not have to ever handle a "backwards" state transition.

ITerminalConnection should represent the things that any connection could do, even after we get a plug-in model. If we can implement restart on top of "stop, delete, create new, start" we can free plugin-in authors from having to think about tracking any of their local state across multiple different sessions, etc.

What do you think about that?

[zadjii-msft]

FWIW I agree with Dustin on this one. I think stashing the ValueSet for the connection settings should be an easy enough way of keeping all the information relevant to starting a new clone of the connection.

[skyline75489]

Yeah you guys are right. This PR is just a demonstration.