Warn before the user runs a new commandline elevated

[zadjii-msft]

targets #11222, followed by #11310

Summary of the Pull Request

As a part of #8455, we identified that we should probably warn before running commandlines, to make sure the user knows what they're about to do. This dialog looks like the following:

When the user approves a commandline, we'll remember that commandline, so they won't get prompted every time.
If they reject a commandline, then we're just going to close that pane.

References

• This is the vegetables so we can do [Question] Configuring Windows Terminal profile to always launch elevated #632
• Scenario: Windows Terminal 2.0 Process Model Improvements #5000

PR Checklist

• Closes Prompt before launching commandlines when elevated ; cache answers in elevated state.json #11096
• I work here
• Tests added/passed
• Requires documentation to be updated - SO very much yes but I'm gonna do it all at the end

Detailed Description of the Pull Request / Additional comments

This PR changes Pane to be able to host any UserControl, not necessarily a TermControl. This of course has bigger repurcussions than just revealed here. It's gonna wildly conflict with some of the other open PRs. I wanted to do this more generically for #997, but alas, nobody got time for that.

This adds a AdminWarningPlaceholder which is a type of UserControl that just holds another UserControl. It looks just like a ContentDialog, but will actually resize as the window resizes.

We won't prompt for certain commandlines:

• Anything that exists in system32 AND IS FULLY QUALIFIED eg C:\windows\system32\cmd.exe.
  • cmd.exe will prompt, because it's unqualified.
  • C:\windows\system32\cmd.exe /k echo sneaky sneak will also prompt, because it's got other args.
• %SystemRoot%\System32\cmd.exe won't prompt, because it's smart enoguh to handle env vars
• %SystemRoot%\System32\wsl.exe -d <distroname> won't prompt, because we trust wsl distros.
• %SystemRoot%\System32\wsl.exe -d <distroname> bash -c do-malicious-shit.sh WILL prompt

Validation Steps Performed

Opened a bunch of terminals, in random orders, and made sure that the above commandlines would work as expected. My list of running profiles:

    {
        "commandline": "%SystemRoot%\\System32\\WindowsPowerShell\\v1.0\\powershell.exe",
        "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
        "hidden": false,
        "name": "Windows PowerShell"
    },
    {
        "commandline": "%SystemRoot%\\System32\\cmd.exe",
        "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
        "hidden": false,
        "name": "Command Prompt"
    },
    {
        "guid": "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
        "hidden": false,
        "name": "PowerShell",
        "source": "Windows.Terminal.PowershellCore"
    },
    {
        "guid": "{c6eaf9f4-32a7-5fdc-b5cf-066e8a4b1e40}",
        "hidden": false,
        "name": "Ubuntu-18.04",
        "source": "Windows.Terminal.Wsl"
    },
    {
        "commandline": "c:\\windows\\system32\\cmd.exe",
        "guid": "{5aea3919-92fa-5990-bb39-2321f316d9b9}",
        "name": "the COOLER cmd",
        "startingDirectory": "%USERPROFILE%"
    },
    {
        "commandline": "c:\\windows\\system32\\cmd.exe /k echo sneaky sneaks",
        "guid": "{4fd85e9a-919a-5033-9118-1b7518b676a7}",
        "name": "the sneaky cmd",
        "startingDirectory": "%USERPROFILE%"
    },
    {
        "background": "#9C1C0C",
        "commandline": "cmd.exe /k echo This profile is always elevated",
        "guid": "{7a7854d2-65bc-57c2-a2c6-70a32a2f600e}",
        "name": "elevated cmd",
        "startingDirectory": "well this is garbage",
        "tabColor": "#9C1C0C"
    },
    {
        "background": "#1C0C9C",
        "commandline": "cmd.exe /k echo This profile is just as elevated as you started with",
        "guid": "{b5c1cbf5-217f-5e0f-b3ee-3c70150ef037}",
        "name": "unelevated cmd",
        "tabColor": "#1C0C9C",
        "useAcrylic": true
    },

[miniksa]

There's still a lot of TODOs here... do you intend to finish those before merge?

[zadjii-msft]

There's still a lot of TODOs here... do you intend to finish those before merge?

Yea, just wanted to push to get it on the cloud before the weekend. Between the three PRs in this chain they'll all get cleaned up.

[DHowett]

So, in the recent 1.13 selfhost builds of Terminal I've been seeing all sorts of weird sizing issues -- sometimes when I launch unpackaged I will get a normal-sized window with a one-column-wide TermControl:

M
i
c
r
o
s
o
f
t

W

Other times -- you know that inverse block of text when powershell starts up telling you about a new version? That looks like it's been resized down and is no longer square (I'll screenshoot next time it happens.)

I wonder if that's related to the changes here that make panes no longer host TermControls?

Further: if you right-click a tab that's displaying an elevation warning and choose "split," terminal crashes.

[DHowett]

There it is-

It's like the opposite of #32!

[zadjii-msft]

So, in the recent 1.13 selfhost builds of Terminal I've been seeing all sorts of weird sizing issues -- sometimes when I launch unpackaged I will get a normal-sized window with a one-column-wide TermControl:

Fix it in post? Couldn't get it repro'd this morning 😕 Were you launching unpackaged, elevated, hitting the dialog, then accepting it? Or just elevated (no prompt)? Or unelevated?

---

Further: if you right-click a tab that's displaying an elevation warning and choose "split," terminal crashes.

That's fixed in 056446c

[DHowett]

Sorry to be a stick in the mud, but unfortunately this path is user-controlled.

(dhowett-sl) ~\src\wt-1.13 % echo hi > $Env:LOCALAPPDATA\Microsoft\WindowsApps\FUN.EXE
(dhowett-sl) ~\src\wt-1.13 % FUN
ResourceUnavailable: Program 'FUN.EXE' failed to run: The specified executable is not a valid application for this OS platform.

[DHowett]

Fix it in post? Couldn't get it repro'd this morning 😕 Were you launching unpackaged, elevated, hitting the dialog, then accepting it? Or just elevated (no prompt)? Or unelevated?

Unelevated, but weirdly I was hitting an issue where OpenConsole.exe wouldn't run. Try running unpackaged, deleting OpenConsole, and then opening wt unelevated. It was a solid 100% repro for my terminal window being the wrong size.