Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2 additional error messages #18462

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add 2 additional error messages #18462

wants to merge 4 commits into from
+24 −2

Conversation

halldk
Copy link

@halldk halldk commented Jan 26, 2025 •
edited
Loading

Add additional information to 2 error scenarios when launching a different profile in the ConptyConnection.cpp file.

  • Requires Elevation
  • File Not Found

Created a profile that required elevation and verified the error message. Created profile that passed a made up command and verified the error message. Unable to test CTRL+C case, but included due to issue conversation.

@halldk
Add 3 additional error messages
556a641 
Add additional information to 3 error senarios when launching a different profile in the ConptyConnection.

  - Requires Elevation
  - CTRL+C
  - Bad Command or File Not Found

closes microsoft#7186
@halldk
Copy link
Author

halldk commented Jan 26, 2025

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Product-Terminal The new Windows Terminal. labels Jan 26, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@halldk
Corrected errors
b15ed43 
  - Removed BadCommand text
  - Added FileNotFound text
KalleOlaviNiemitalo
KalleOlaviNiemitalo suggested changes Jan 27, 2025
View reviewed changes
Copy link

@KalleOlaviNiemitalo KalleOlaviNiemitalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Ctrl+C

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 27, 2025
@halldk halldk changed the title Add 3 additional error messages Add 2 additional error messages Jan 27, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalleOlaviNiemitalo KalleOlaviNiemitalo Awaiting requested review from KalleOlaviNiemitalo

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Area-TerminalConnection Issues pertaining to the terminal<->backend connection interface Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a more descriptive error message when the ConptyConnection fails to start for some reason
2 participants
@halldk @KalleOlaviNiemitalo