Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fontSize and acrylicOpacity changing tip #1889

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

gautamnaik1994
Copy link
Contributor

Summary of the Pull Request

Added Terminal tip about changing the font size and acrylic opacity using keyboard shortcuts.
Ctrl+mouse scroll to change font size
Ctrl+Shift + mouse scroll to change acrylic opacity given useAcrylic is set to true in profiles.json.

Added Terminal tip about changing the font size and acrylic opacity using keyboard shortcuts.
@cinnamon-msft
Copy link
Contributor

I would recommend changing the tips to not include properties from the profiles.json file, given that these keyboard shortcuts don't change the values within the settings.
For the first tip I think "zoom" is a better alternative, and for the second I'd say "background opacity" 😊

@@ -85,4 +85,6 @@ The list of valid settings can be found in the [Profiles.json Documentation](../

(ref https://twitter.com/r_keith_hill/status/1142871145852440576)

2. Please add more Tips and Tricks
2. Terminal `fontSize` can be changed by holding `Ctrl` and scrolling with mouse.
3. Terminal `acrylicOpacity` can be changed by holding `Ctrl+Shift` and scrolling with mouse given `useAcrylic` is set to `true` in profiles.json.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: reorganize sentence to start with something like "If useAcrylic is enabled for the profile..."

Copy link
Contributor Author

@gautamnaik1994 gautamnaik1994 Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced "fontSize" with "zoom", "acrylicOpacity" with "background opacity" and also reorganized the sentence

@carlos-zamora carlos-zamora merged commit cfbc9e8 into microsoft:master Jul 9, 2019
mcpiroman pushed a commit to mcpiroman/terminal that referenced this pull request Jul 23, 2019
* Added fontSize and acrylicOpacity changing tip

Added Terminal tip about changing the font size and acrylic opacity using keyboard shortcuts.

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants