Add a schema reference to the userDefaults and patch one into user data #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oising
reviewed
Sep 18, 2019
| @@ -36,6 +37,8 @@ static constexpr std::string_view DisabledProfileSourcesKey{ "disabledProfileSou | |||
|
|
|||
| static constexpr std::string_view Utf8Bom{ u8"\uFEFF" }; | |||
| static constexpr std::string_view DefaultProfilesIndentation{ " " }; | |||
| static constexpr std::string_view SettingsSchemaFragment{ "\n" | |||
| R"( "$schema": "https://aka.ms/terminal-profiles-schema",)" }; | |||
There was a problem hiding this comment.
My regex monstrosity is alive!
There was a problem hiding this comment.
you calling out this line taught me that we will almost certainly corrupt a user's profile if we hardcode the , here. More thought is required. 😁
zadjii-msft
approved these changes
Sep 18, 2019
|
I owe tests on this, but we don't seem to have any patching tests anywhere. I'm going to defer that to work on #2805. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request both adds a schema to the default JSON file written out for the user and adds code to patch a
$schemainto existing user settings.References
#2704
PR Checklist
Detailed Description of the Pull Request / Additional comments
We have to re-parse the settings string after every patch, because there's a chance the object offsets have moved around on us. Alternatively, we could always patch from the bottom up. That approach seems more fragile, even if it's technically faster.
Validation Steps Performed
The tests probably fail, but I tried it locally against my settings file :P