-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WT_PROFILE_ID to the environment of the spawned process #4852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly this looks okay to me. Plumbing the StringMap
through makes it easier to add some of the other requests (looking at #3589) as well.
I've just got some nits about dead code, but the changes to OpenConsole.sln
probably shouldn't be here. That's literally the only thing blocking me
(On account of you deleted your comment, I'm guessing something else was up 😉) |
If it was me, I realized my comment was incorrect, it was special local config I did. All is good and looking forward to seeing this in 0.11! |
Hey @DHowett-MSFT -- did I miss something? Do I need to update the PR? |
@oising this was directed at me I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
That's disappointing. You guys are shipping 1.0 without a means to edit settings from the UI, and now making it even harder to find the files if you do need to edit them. |
I mean, Ctrl+, will open the settings file by default, and Just because it's not making the 1.0 cut doesn't mean it's never happening. It's not like we're gonna ship 1.0 then all get the 'rona and disappear. We just need to make hard cuts on what actually gets in at this point unfortunately (case in point #3789). We'll certainly come back to this |
In my opinion, the thing that's really missing in 1.0 is WT_PROFILE_ID (#3589 which cannot be discovered at all ... @zadjii-msft And since the VT color queries were also never finished, there's no way to discover what crazy colors someone's using in their terminal |
The PR is blocked until after 1.0, but it looks like this is what they're going to use microsoft/terminal#4852
…terminal into feature/profile-env-vars
As per discussion with @DHowett-MSFT at #4566 (comment) - removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one concern. Thanks Oisin!
Co-Authored-By: Dustin L. Howett (MSFT) <duhowett@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM thanks so much Oisin
Hello @DHowett-MSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Thanks for rethinking this one, y'all. |
🎉 Handy links: |
* Add Windows Terminal adapter * [Windows Terminal] Get defaultProfile on globals * [Windows Terminal] Update with latest version - profiles.json to settings.json microsoft/terminal#5199 - Change current profile microsoft/terminal#4852 * [Windows Terminal] Rename adapter to pass tests * [Windows Terminal] Update with default profile settings https://github.com/microsoft/terminal/blob/master/doc/user-docs/UsingJsonSettings.md#default-settings
This commit adds a
WT_PROFILE_ID
environment variable, which containsthe guid of the active profile.
It also teaches ConptyConnection to take an environment map on creation.
We had to do a little manual jiggery with the WSLENV environment
variable as passed by the creator.
Ran terminal, validated vars and translated paths under windows and WSL.
References #4566 (this PR originally introduced WT_SETTINGS/DEFAULTS)
Closes #3589