-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a heap of legacy settings deserialization #5190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Mar 31, 2020
carlos-zamora
requested changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the docs
ghost
added
Needs-Author-Feedback
The original author of the issue/PR needs to come back and respond to something
and removed
Needs-Author-Feedback
The original author of the issue/PR needs to come back and respond to something
labels
Mar 31, 2020
carlos-zamora
approved these changes
Mar 31, 2020
DHowett-MSFT
changed the title
Remove a bunch of legacy settings deserialization
Remove a heap of legacy settings deserialization
Mar 31, 2020
🎉 Handy links: |
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for:
colorScheme.colors
, as an arrayglobals
object in the root of the settings fileprofile.colorTable
andprofile.colorscheme
(the rare v0.1 all-lowercase variety)c637a67 - Settings: delete all legacy keybinding deserializers
fc0d22e - Settings: remove support for colorScheme.colors (array)
e3bc5a9 - Settings: remove legacy colorscheme key and colorTable
bba1d65 - Settings: Remove support for /globals
Fixes #4091.
Fixes #1069.