-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for "fragment extensions" #7632
Conversation
…ev/pabhoj/proto_ext
…ev/pabhoj/proto_ext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'm happy with this
Eventually, we can move it to a common shared location.
…/pabhoj/proto_ext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just do it!
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
@PankajBhojwani @zadjii-msft I'm trying to use this feature with the latest preview release. I wanted to put all the color schemes in a separate json so as to not clutter the settings.json file. Not sure if that's valid/feasible or makes sense - let me know if it's not and I'll abandon. Reading the documentation, it's not clear to me where (path/folder) I would put this json extension file at? I believe I downloaded preview from github releases page if not from the Store - I'm not recalling with certainty now. Tried creating a file |
Pretty sure it has to be something like
|
Tried it with no luck:
|
For the record, just adding the file, or modifying fragments, won't cause a "hot reload" of the settings - you'll need to |
I relaunched the terminal for a good measure but still no joy. |
Oh you've got one too many braces in that scheme! {
"profiles": [
],
"schemes": [
{
"name": "Test Extension",
"background": "#19171c",
"foreground": "#8b8792",
"black": "#19171c",
"red": "#be4678",
"green": "#2a9292",
"yellow": "#a06e3b",
"blue": "#576ddb",
"purple": "#955ae7",
"cyan": "#398bc6",
"white": "#8b8792",
"brightBlack": "#655f6d",
"brightRed": "#be4678",
"brightGreen": "#2a9292",
"brightYellow": "#a06e3b",
"brightBlue": "#576ddb",
"brightPurple": "#955ae7",
"brightCyan": "#398bc6",
"brightWhite": "#efecf4"
}
]
} |
D'oh! That was it! Thanks so much for your time and kindness (and good eyes!). |
Is there some docs for how to make, build and publish on the Windows Store an extension that adds a single JSON fragment? |
@NatoBoram Found this: https://docs.microsoft.com/en-us/windows/terminal/json-fragment-extensions |
Not really. This assumes I have an app where I can stick this JSON fragment, but I don't. I want to make an app that's only a JSON fragment. Once I have created a folder that contains this mysterious |
Support for fragment extensions, according to the implementation
outlined in #7584 (which calls them proto extensions.)
See #7584 for more information.
Validation Steps Performed
Self-testing by creating the folder
%LOCALAPPDATA%\Microsoft\Windows Terminal\Fragments
and adding a json file into it to modify and add profiles
Also self-tested with an app extension
Closes #1690